London | SDC-Nov-2025| Ikenna Agulobi | Sprint 5| Prep exercise python #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t it does report and error
This comment has been minimized.
This comment has been minimized.
ike-agu
changed the title
ike-agu
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jan 14, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Very good work on these tasks, there are some areas where you could improve further
There was a problem hiding this comment.
Has this file passed the mypy type checker?
There was a problem hiding this comment.
Can you describe the difference and any dis/advantage of using a class method vs a function?
| def print_family_tree(person: Person) -> None: | ||
| print(person.name) | ||
| for child in person.children: | ||
| print(f"- {child.name} ({child.age})") |
There was a problem hiding this comment.
Can this print grandchildren recursively?
| if best_os != person.preferred_operating_system and best_count > preferred_count: | ||
| print( | ||
| f"If you are willing to accept {best_os.value} instead," | ||
| f"You're more likely to get a laptop. {best_count} available)." |
There was a problem hiding this comment.
I think you have an extra bracket here you dont need
LonMcGregor
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR contains my sprint 5 prep exercises: